Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Magento 2.2. compatibility #16

Closed
wants to merge 4 commits into from
Closed

Magento 2.2. compatibility #16

wants to merge 4 commits into from

Conversation

Tjitse-E
Copy link

  • Removed Magento 2.2 constraint in composer.json
  • Removed support for PHP 5.6, because of type hint change
  • Fixed M2.2 DI compilation errors:
	PHPCuong\Faq\Model\ResourceModel\Faq\Grid\Collection
		Incompatible argument type: Required type: \Magento\Framework\DB\Adapter\AdapterInterface. Actual type: \PHPCuong\Faq\Model\ResourceModel\Faq\Grid\connection; File:
/vendor/php-cuong/magento2-faqs-extensions/Model/ResourceModel/Faq/Grid/Collection.php

	PHPCuong\Faq\Model\ResourceModel\Faqcat\Grid\Collection
		Incompatible argument type: Required type: \Magento\Framework\DB\Adapter\AdapterInterface. Actual type: \PHPCuong\Faq\Model\ResourceModel\Faqcat\Grid\connection; File:
/vendor/php-cuong/magento2-faqs-extensions/Model/ResourceModel/Faqcat/Grid/Collection.php

	PHPCuong\Faq\Model\ResourceModel\Faqcat
		Incompatible argument type: Required type: string. Actual type: \PHPCuong\Faq\Model\ResourceModel\connectionName; File:
/vendor/php-cuong/magento2-faqs-extensions/Model/ResourceModel/Faqcat.php

Total Errors Count: 3


  [Magento\Framework\Validator\Exception]
  Error during compilation

@samoudi2006
Copy link

Good
thank you

@danslo
Copy link

danslo commented Oct 25, 2017

@Tjitse-E Another good idea here would be to remove the 'version' part in composer.json. It's not needed when properly using tags (which this repository is doing).

It's not needed when properly using tags (which this repository is doing).
@php-cuong php-cuong closed this Nov 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants