$decimal->toInt() for -INF, INF, NAN give not correct result (zero)

[FoxKeys]

Hello again.

I have found that $decimal->toInt() return 0 for -INF, INF and NAN.
I suppose, this is wrong. OverflowException seems to be correct for +-INF. And another exception (Invalid_Operation?) for NAN

[rtheunissen]

This is intended, as it matches PHP behaviour.

See: https://3v4l.org/oLkmS

Ref: https://github.com/php-decimal/ext-decimal/blob/master/php_decimal.c#L780

[rtheunissen]

Leaving this open because I am not convinced that matching PHP behaviour is the right way to go here. Thanks for bringing this up. 👍

[FoxKeys]

I think PHP-way looks not relevant int this case.

You throw OverflowException if the value is greater than PHP_INT_MAX (this seems ok). But, +INF is greater than PHP_INT_MAX. Therefore, +INF must give overfloaw too. Same for -INF, i suppose.

[rtheunissen]

This has been fixed in b1e0162 and released as v1.2.0 ✨

Throws RuntimeException for INF, -INF and NAN.