Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[config.w32] json is static in PHP 8 #162

Merged
merged 1 commit into from
Oct 23, 2020
Merged

[config.w32] json is static in PHP 8 #162

merged 1 commit into from
Oct 23, 2020

Conversation

Jan-E
Copy link
Contributor

@Jan-E Jan-E commented Oct 22, 2020

@rtheunissen
json is built statically in PHP 8
See php/php-src#5495
It is always there and cannot be made a dependency with an ADD_EXTENSION_DEP command.

@rtheunissen rtheunissen merged commit 31360d7 into php-ds:master Oct 23, 2020
@rtheunissen
Copy link
Member

Thank you

@Jan-E Jan-E deleted the config-w32-fix-php8 branch October 23, 2020 17:34
@Jan-E Jan-E mentioned this pull request Oct 23, 2020
Closed
@Jan-E
Copy link
Contributor Author

Jan-E commented Oct 23, 2020

BTW See mongodb/mongo-php-driver#1161 (comment) for a similar case.

@cmb69
Copy link
Contributor

cmb69 commented Oct 24, 2020

I think you can revert this, since the root cause has been fixed with php/php-src@5609701 now (available as of PHP 8.0.0RC3, scheduled for Oct, 29th).

@Jan-E
Copy link
Contributor Author

Jan-E commented Oct 24, 2020

I can confirm this commit can be reverted after php/php-src@5609701

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Jan-E @rtheunissen @cmb69