Updated PHPStan level from 3 to 8

.github/workflows/phpstan-5.yaml → .github/workflows/phpstan-9.yaml

@@ -1,4 +1,4 @@
-name: PHPStan level 5
+name: PHPStan level 9
 on: push
 jobs:
   phpstan:
@@ -19,5 +19,5 @@ jobs:
         uses: php-actions/phpstan@v3
         with:
           path: src/
-          level: 5
+          level: 9
           php_version: '8.2'

.github/workflows/quality.yaml

@@ -1,4 +1,4 @@
-name: Quality
+name: Quality (PHPSpec level 8)
 on: push
 jobs:
   cs-fixer:
@@ -34,5 +34,5 @@ jobs:
         uses: php-actions/phpstan@v3
         with:
           path: src/
-          level: 3
+          level: 8
           php_version: '8.2'

src/BuilderTestCase.php

@@ -25,6 +25,10 @@ protected function tearDown(): void
 
     protected function getBuilderCompilePath(): string
     {
+        if ($this->fs === null) {
+            throw new \RuntimeException('The virtual file system was not initialized. The '.__METHOD__.' method should be called after the '.get_class($this).'::setUp() method was called and after the '.get_class($this).'::tearDown() method is called.');
+        }
+
         return $this->fs->url();
     }
 

src/Constraint/Pipeline/PipelineExtractsLike.php

@@ -4,6 +4,7 @@
 
 namespace Kiboko\Component\PHPUnitExtension\Constraint\Pipeline;
 
+use Kiboko\Contract\Bucket\ResultBucketInterface;
 use Kiboko\Contract\Pipeline\ExtractorInterface;
 use Kiboko\Contract\Pipeline\NullStepRejection;
 use Kiboko\Contract\Pipeline\NullStepState;
@@ -26,9 +27,11 @@ public function __construct(
     }
 
     /**
-     * @param list<Type> $iterable
+     * @template ItemType
      *
-     * @return \Iterator<Type>
+     * @param list<ItemType> $iterable
+     *
+     * @return \Iterator<ItemType>
      */
     private function asIterator(iterable $iterable): \Iterator
     {

src/Mock/ApiClientMockBuilder.php

@@ -17,7 +17,7 @@ final class ApiClientMockBuilder implements Builder
     /** @param array<Node\Arg|Node\VariadicPlaceholder> $mockedArgs */
     public function __construct(
         private readonly string $mockedClientBuilder,
-        private readonly ?array $mockedArgs = []
+        private readonly array $mockedArgs = []
     ) {
         $this->node = new Node\Expr\New_(
             class: new Node\Name\FullyQualified($this->mockedClientBuilder),