Change visibility generateId() method. (#239)

php-forge · Jan 12, 2024 · 059d87c · 059d87c
1 parent a194ad9
commit 059d87c
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 30 deletions.
diff --git a/src/Attribute/HasId.php b/src/Attribute/HasId.php
@@ -37,7 +37,7 @@ public function id(string|null $value): static
      *
      * @return string|null A unique ID for the widget.
      */
-    public function generateId(string $value = 'id_'): string|null
+    protected function generateId(string $value = 'id_'): string|null
     {
         return $this->id === '' ? uniqid($value) : $this->id;
     }

diff --git a/tests/Attribute/HasIdTest.php b/tests/Attribute/HasIdTest.php
@@ -19,33 +19,4 @@ public function testImmutability(): void
 
         $this->assertNotSame($instance, $instance->id(''));
     }
-
-    public function testGenerateId(): void
-    {
-        $instance = new class () {
-            use HasId;
-
-            protected array $attributes = [];
-        };
-
-        $instance = $instance->id('');
-
-        $this->assertNotEmpty($instance->generateId());
-        $this->assertMatchesRegularExpression('/^id_[a-z0-9]{13}$/', $instance->generateId());
-        $this->assertMatchesRegularExpression('/^alert_[a-z0-9]{13}$/', $instance->id('')->generateId('alert_'));
-    }
-
-    public function testGenerateIdWithId(): void
-    {
-        $instance = new class () {
-            use HasId;
-
-            protected array $attributes = [];
-        };
-
-
-        $instance = $instance->id('foo');
-
-        $this->assertSame('foo', $instance->generateId());
-    }
 }