Remove unused isNotLabel method and update code to use notLabel prope…

…rty. (#235)
php-forge · Jan 12, 2024 · 22ff2b5 · 22ff2b5
1 parent fe9ec4c
commit 22ff2b5
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 32 deletions.
diff --git a/src/Attribute/Custom/HasLabel.php b/src/Attribute/Custom/HasLabel.php
@@ -94,16 +94,6 @@ public function notLabel(): static
         return $new;
     }
 
-    /**
-     * Determine if the label is disabled or not.
-     *
-     * @return bool `true` if the label is disabled, `false` otherwise.
-     */
-    public function isNotLabel(): bool
-    {
-        return $this->notLabel;
-    }
-
     /**
      * Render the label tag.
      *
@@ -113,7 +103,7 @@ public function isNotLabel(): bool
      */
     protected function renderLabelTag(string $labelFor = null): string
     {
-        if ($this->labelContent === '' || $this->isNotLabel()) {
+        if ($this->labelContent === '' || $this->notLabel) {
             return '';
         }
 

diff --git a/src/Input/Base/AbstractInputChoice.php b/src/Input/Base/AbstractInputChoice.php
@@ -126,7 +126,7 @@ private function prepareTemplate(string $tag, string $labelTag): string
 
     private function renderEnclosedByLabel(string $tag, string $labelFor): string
     {
-        if ($this->labelContent === '' || $this->isNotLabel()) {
+        if ($this->labelContent === '' || $this->notLabel) {
             return $tag;
         }
 

diff --git a/src/Input/Contract/LabelInterface.php b/src/Input/Contract/LabelInterface.php
@@ -20,13 +20,6 @@ interface LabelInterface
      */
     public function enclosedByLabel(bool $value): static;
 
-    /**
-     * Determine if the label is disabled or not.
-     *
-     * @return bool `true` if the label is disabled, `false` otherwise.
-     */
-    public function isNotLabel(): bool;
-
     /**
      * Set the `HTML` attributes for the label.
      *

diff --git a/tests/Attribute/Custom/HasLabelTest.php b/tests/Attribute/Custom/HasLabelTest.php
@@ -66,27 +66,17 @@ public function testImmutability(): void
         $this->assertNotSame($instance, $instance->notLabel());
     }
 
-    public function testIsNotLabel(): void
+    public function testNotLabel(): void
     {
         $instance = new class () {
             use HasLabel;
 
-            public function getIsNotLabel(): bool
+            public function isNotLabel(): bool
             {
-                return $this->isNotLabel();
+                return $this->notLabel;
             }
         };
 
-        $this->assertTrue($instance->notLabel()->getIsNotLabel());
-        $this->assertFalse($instance->getIsNotLabel());
-    }
-
-    public function testNotLabel(): void
-    {
-        $instance = new class () {
-            use HasLabel;
-        };
-
         $this->assertFalse($instance->isNotLabel());
         $this->assertTrue($instance->notLabel()->isNotLabel());
     }