Add listItemContainerTag property to HasListItemContainer trait. (#190)

php-forge · Dec 31, 2023 · 65283a3 · 65283a3
1 parent 79893e6
commit 65283a3
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 12 deletions.
diff --git a/src/Attribute/Component/HasListItemContainer.php b/src/Attribute/Component/HasListItemContainer.php
@@ -14,6 +14,7 @@ trait HasListItemContainer
 {
     protected bool $listItemContainer = false;
     protected array $listItemContainerAttributes = [];
+    protected string $listItemContainerTag = 'div';
 
     /**
      * Enable or disable the container tag for list items.

diff --git a/tests/Attribute/Component/HasListItemContainerTest.php b/tests/Attribute/Component/HasListItemContainerTest.php
@@ -15,8 +15,6 @@ public function testClass(): void
         $instance = new class () {
             use HasListItemContainer;
 
-            protected string $listItemContainerTag = 'div';
-
             public function getListItemContainerClass(): string
             {
                 return $this->listItemContainerAttributes['class'] ?? '';
@@ -25,25 +23,23 @@ public function getListItemContainerClass(): string
 
         $this->assertEmpty($instance->getListItemContainerClass());
 
-        $instance = $instance->listItemContainerClass('test-class');
+        $instance = $instance->listItemContainerClass('class');
 
-        $this->assertSame('test-class', $instance->getListItemContainerClass());
+        $this->assertSame('class', $instance->getListItemContainerClass());
 
-        $instance = $instance->listItemContainerClass('test-class-1');
+        $instance = $instance->listItemContainerClass('class-1');
 
-        $this->assertSame('test-class test-class-1', $instance->getListItemContainerClass());
+        $this->assertSame('class class-1', $instance->getListItemContainerClass());
 
-        $instance = $instance->listItemContainerClass('test-override-class', true);
+        $instance = $instance->listItemContainerClass('override-class', true);
 
-        $this->assertSame('test-override-class', $instance->getListItemContainerClass());
+        $this->assertSame('override-class', $instance->getListItemContainerClass());
     }
 
     public function testException(): void
     {
         $instance = new class () {
             use HasListItemContainer;
-
-            protected string $listItemContainerTag = '';
         };
 
         $this->expectException(InvalidArgumentException::class);
@@ -56,8 +52,6 @@ public function testImmutability(): void
     {
         $instance = new class () {
             use HasListItemContainer;
-
-            protected string $listContainerTag = 'div';
         };
 
         $this->assertNotSame($instance, $instance->listItemContainer(true));