Refactor template rendering logic in several classes. (#177)

php-forge · Dec 29, 2023 · 728d15f · 728d15f
1 parent b87f510
commit 728d15f
Show file tree

Hide file tree

Showing 4 changed files with 39 additions and 57 deletions.
diff --git a/src/Attribute/Custom/HasTemplate.php b/src/Attribute/Custom/HasTemplate.php
@@ -4,6 +4,8 @@
 
 namespace PHPForge\Html\Attribute\Custom;
 
+use function explode;
+
 /**
  * Is used by widgets that implement the template method.
  */
@@ -33,4 +35,24 @@ public function tokenValue(string $token, string $value): static
 
         return $new;
     }
+
+    private function renderTemplate(string $template, array $tokenValues): string
+    {
+        $result = '';
+        $tokens = explode('\n', $template);
+
+        foreach ($tokens as $key => $token) {
+            $tokenValue = strtr($token, $tokenValues);
+
+            if ($tokenValue !== '') {
+                $result .= $tokenValue;
+            }
+
+            if ($result !== '' && $key < count($tokens) - 1) {
+                $result = strtr($tokens[$key + 1], $tokenValues) !== '' ? $result . "\n" : $result;
+            }
+        }
+
+        return $result;
+    }
 }
diff --git a/src/Base/AbstractElement.php b/src/Base/AbstractElement.php
@@ -43,28 +43,13 @@ protected function run(): string
             $attributes['id'] = $this->id;
         }
 
-        $result = '';
         $tokenValues = [
             '{prefix}' => $this->renderPrefixTag(),
             '{tag}' => HtmlBuilder::create($this->tagName, $this->content, $attributes),
             '{suffix}' => $this->renderSuffixTag(),
         ];
         $tokenValues += $this->tokenValue;
 
-        $tokens = explode('\n', $this->template);
-
-        foreach ($tokens as $key => $token) {
-            $tokenValue = strtr($token, $tokenValues);
-
-            if ($tokenValue !== '') {
-                $result .= $tokenValue;
-            }
-
-            if ($result !== '' && isset($tokens[$key + 1])) {
-                $result = strtr($tokens[$key + 1], $tokenValues) !== '' ? $result . "\n" : $result;
-            }
-        }
-
-        return $result;
+        return $this->renderTemplate($this->template, $tokenValues);
     }
 }
diff --git a/src/ButtonToggle.php b/src/ButtonToggle.php
@@ -86,25 +86,15 @@ protected function run(): string
             $attributes['data-toggle'] = $this->toggleId;
         }
 
-        $result = '';
         $tokenValues = [
             '{toggle}' => $this->renderToggleTag(),
             '{icon}' => $this->renderIconTag(),
             '{content}' => $this->content,
         ];
         $tokenValues += $this->tokenValue;
 
-        $tokens = explode('\n', $this->template);
-
-        foreach ($tokens as $token) {
-            $tokenValue = strtr($token, $tokenValues);
-
-            if ($tokenValue !== '') {
-                $result .= $tokenValue . "\n";
-            }
-        }
-
-        $content = $result !== '' ? PHP_EOL . $result : '';
+        $content = $this->renderTemplate($this->template, $tokenValues);
+        $content = $content !== '' ? PHP_EOL . $content . PHP_EOL : '';
 
         return Button::widget()
             ->ariaDescribedBy($this->ariaDescribedBy)

diff --git a/src/Input/Base/AbstractInputChoice.php b/src/Input/Base/AbstractInputChoice.php
@@ -92,11 +92,24 @@ protected function buildChoiceTag(string $type): string
             $labelTag = $this->renderLabelTag($this->getId() ?? '');
         }
 
-        $choiceTag = $this->renderTemplate($tag, $labelTag);
+        $choiceTag = $this->prepareTemplate($tag, $labelTag);
 
         return $this->renderContainerTag($choiceTag);
     }
 
+    private function prepareTemplate(string $tag, string $labelTag): string
+    {
+        $tokenValues = [
+            '{prefix}' => $this->renderPrefixTag(),
+            '{unchecktag}' => $this->renderUncheckTag(),
+            '{tag}' => $tag,
+            '{label}' => $labelTag,
+            '{suffix}' => $this->renderSuffixTag(),
+        ];
+
+        return $this->renderTemplate($this->template, $tokenValues);
+    }
+
     private function renderEnclosedByLabel(string $tag): string
     {
         if ($this->labelContent === '' || $this->isNotLabel()) {
@@ -115,32 +128,4 @@ private function renderEnclosedByLabel(string $tag): string
             ->for($this->getId())
             ->render();
     }
-
-    private function renderTemplate(string $tag, string $labelTag): string
-    {
-        $result = '';
-        $tokenValues = [
-            '{prefix}' => $this->renderPrefixTag(),
-            '{unchecktag}' => $this->renderUncheckTag(),
-            '{tag}' => $tag,
-            '{label}' => $labelTag,
-            '{suffix}' => $this->renderSuffixTag(),
-        ];
-
-        $tokens = explode('\n', $this->template);
-
-        foreach ($tokens as $key => $token) {
-            $tokenValue = strtr($token, $tokenValues);
-
-            if ($tokenValue !== '') {
-                $result .= $tokenValue;
-            }
-
-            if ($result !== '' && isset($tokens[$key + 1])) {
-                $result = strtr($tokens[$key + 1], $tokenValues) !== '' ? $result . "\n" : $result;
-            }
-        }
-
-        return $result;
-    }
 }