Remove direct references to class Translation
#234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To make the class `Translation` extensible without introducing bugs, the `Translations` class was now adapted to accept a class name of a Translation object to use. This makes sure that when you extend `Translation`, you can enforce use of that extension even when `Translations` needs to create new instances of it. `Translation` also has a `create()` method now so that when you have an instance of a translation you can easily create a new one without needing to know the exact class name.
swissspidy
reviewed
Oct 17, 2019
swissspidy
approved these changes
Oct 17, 2019
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make the class
Translationextensible without introducing bugs, theTranslationsclass was now adapted to accept a class name of a Translation object to use.This makes sure that when you extend
Translation, you can enforce use of that extension even whenTranslationsneeds to create new instances of it.Translationalso has acreate()method now so that when you have an instance of a translation you can easily create a new one without needing to know the exact class name.Related issue: #231