Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gnupg.c: fix gnupg_adddecryptkey() passphrase handling #15

Closed

Conversation

TerraTech
Copy link

This corrects an issue where the given passphrase was not being respected and
pinentry was being called regardless. This fix will set the pinentry_mode to loopback
mode so that our custom passphrase_decrypt_cb() function will be called.

  This corrects an issue where the given passphrase was not being respected and
    pinentry was being called regardless.  This fix will set the pinentry_mode to loopback
    mode so that our custom passphrase_decrypt_cb() function will be called.
@TerraTech
Copy link
Author

FWIW - this was rebased to master based on the fix against tag 1.4.0 which has been tested and is working properly.
https://github.com/TerraTech/php-gnupg/tree/fix_adddecryptkey_passphrase-1.4.0

@bukka
Copy link
Member

bukka commented Jun 4, 2018

It's already fixed in master: 8c55c26 . Btw. this issue is just for GnuPG 2.1+..

@bukka bukka closed this Jun 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants