feat: header authentication service configuration

[soullivaneuh]

Q	A
Bug fix?	no
New feature?	yes
BC breaks?	no
Deprecations?	no
Related tickets	fixes #437
Documentation	php-http/documentation#313
License	MIT

What's in this PR?

Exposes configuration for the header authentication plugin.

Why?

Allows the direct usage of this plugin through the bundle configuration.

Example Usage

  - authentication:
      header:
          type: header
          key: "ApiKey"
          value: "%env(SAMPLE_API_TOKEN)%"

Checklist

• Updated CHANGELOG.md to describe BC breaks / deprecations | new feature | bugfix
• Documentation pull request created (if not simply a bugfix)

To Do

N/A

[soullivaneuh]

I am not sure of what I did wrong to make some tests crying. May you give me a hint @dbu?

[soullivaneuh]

I found the reason. Apparently, it is because we are declaring the name scalar value that make the configuration process being confused as name is also used as a key attribute: https://github.com/pocivaneuh/HttplugBundle/blob/32caa9a2c95a4da393a0a91205ea904fe3c53960/src/DependencyInjection/Configuration.php#L640

I changed to key instead: 32caa9a

[soullivaneuh]

All green! 👍 I also updated the documentation PR according to the configuration key name change.

[dbu]

ah right, i think that is for xml where you can't have a custom xml element and we use name as identifier attribute. in yaml its the my_auth: part, and does not need an explicit name.

should we call the thing header_name instead of key? key is a bit generic and could be confusing in the context of security. it boils down to what header name to set in the request.

[soullivaneuh]

Oh that case, header_name and header_value to make things consistent?

[dbu]

yes, i like header_name and header_value. that makes it really clear and leaves no room for confusion (i hope :-) )

[soullivaneuh]

@dbu keys named was changed in 04414b2.

Squashed and rebased, ready for review! 👍

[dbu]

thanks!