Add config for enable FlexibleHttpClient and HttpMethodsClient #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| */ | ||
|
|
||
| if ($arguments['flexible_client'] && $arguments['add_http_methods']) { | ||
| throw new \LogicException('A http client can\'t be decorated with both FlexibleHttpClient and HttpMethodsClient. Only one of the following options can be true. ("flexible_client", "add_http_methods")'); |
There was a problem hiding this comment.
this should be validated in the Configuration class. you can add a validate() section (or was it validation()?) on the level that has the two options.
|
the name flexible_client seems right to me. i would call the other http_methods_client. |
|
Thank you for your review. I've update the PR according to your suggestions |
|
thanks a lot @Nyholm ! |
|
Thank you for merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will address part of #70
With config options you wrap your client in FlexibleHttpClient or HttpMethodsClient. Please give input on the config names. I want them to be descriptive but at the same time also reflect the class we use for wrapping.
A descriptive config name would be "emulate_async_client" but that is very far from the name
FlexibleHttpClient. I guess you understand my point. Any suggestions are welcome.