Skip to content
This repository has been archived by the owner on Jan 6, 2024. It is now read-only.

Make sure we throw a NetworkException on timeouts. #16

Merged
merged 2 commits into from Aug 8, 2017
Merged

Make sure we throw a NetworkException on timeouts. #16

merged 2 commits into from Aug 8, 2017

Conversation

Nyholm
Copy link
Member

@Nyholm Nyholm commented Aug 5, 2017

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Related tickets fixes #14
Documentation
License MIT

@Nyholm Nyholm requested a review from dbu August 8, 2017 05:03
dbu
dbu approved these changes Aug 8, 2017
View reviewed changes
Copy link
Contributor

@dbu dbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me. making the exception more specific might be relevant for some users.

@Nyholm
Copy link
Member Author

Nyholm commented Aug 8, 2017

Thank you for the review.

@Nyholm Nyholm merged commit c174df3 into master Aug 8, 2017
@Nyholm Nyholm deleted the nyholm-timeout branch August 8, 2017 06:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dbu dbu dbu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Throw NetworkException on timeout
2 participants
@Nyholm @dbu