Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make clients final #20

Closed
9 tasks done
sagikazarmark opened this issue Mar 31, 2016 · 5 comments
Closed
9 tasks done

Make clients final #20

sagikazarmark opened this issue Mar 31, 2016 · 5 comments
Milestone
v2.0.0

Comments

@sagikazarmark
Copy link
Member

sagikazarmark commented Mar 31, 2016 •
edited by dbu
Loading

Q A
Bug? no
New Feature? yes
Version 2.0.0

Make the rest of clients final. See #18 and #19

  • BatchClient
  • BatchResult
  • Deferred
  • LeastUsedClientPool
  • RoundRobinClientPool
  • HttpMethodsClient
  • PluginClient
  • PluginClientFactory
  • All Plugins
@sagikazarmark sagikazarmark added this to the v2.0.0 milestone Mar 31, 2016
sagikazarmark added a commit that referenced this issue Mar 31, 2016
@sagikazarmark
Make clients final
94537ea 
Make not-yet-released clients final

Update changelog

Remove TODOs in favor of #20
sagikazarmark added a commit that referenced this issue Mar 31, 2016
@sagikazarmark
Make clients final
c8863d6 
Make not-yet-released clients final

Update changelog

Remove TODOs in favor of #20
sagikazarmark added a commit that referenced this issue Apr 2, 2016
@sagikazarmark
Make clients final
4acafff 
Make not-yet-released clients final

Update changelog

Remove TODOs in favor of #20
@dbu
Copy link
Contributor

dbu commented Nov 21, 2018

updated description, i think we should also make all other classes that are not meant to be extended final.

@dbu dbu mentioned this issue Nov 21, 2018
Merged
3 tasks
@Jean85
Copy link
Contributor

Jean85 commented Nov 22, 2018

I was trying to address this issue, but making the last non-final plugin final (RedirectPlugin) is pretty hard, since the class is extended in the specs to create stubs. This is obviously wrong because it tries to test internal behavior, but I'm not be able to solve that easily. Anyone else up for this?

@Jean85 Jean85 mentioned this issue Nov 22, 2018
Closed
5 tasks
@dbu
Copy link
Contributor

dbu commented Nov 22, 2018

i guess thats why its not yet final :-/
can you do a pull request with all that works, and a note that the RedirectPlugin is missing? maybe mark can see if he finds a better way for the testing of that plugin?

@sagikazarmark
Copy link
Member Author

Yup, will take a look at it: #21

@dbu dbu mentioned this issue Dec 2, 2018
Merged
1 task
@dbu
Copy link
Contributor

dbu commented Dec 25, 2018

i think we now made final everything that can be final

@dbu dbu closed this as completed Dec 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.0.0
Development

No branches or pull requests
3 participants
@dbu @sagikazarmark @Jean85