Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compatibility with PHPUnit 6 #20

Merged
merged 1 commit into from Mar 17, 2017

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Mar 17, 2017

Q A
Bug fix? no
New feature? yes
BC breaks? yes (dropped support for PHPUnit versions that do not have the FC layer for namespaced PHPUnit classes)
Deprecations? no
Related tickets
Documentation
License MIT

What's in this PR?

Makes the package compatible with all PHPUnit versions that support the namespaced test case class.

Why?

In PHPUnit 6, the PHPUnit_Framework_TestCase class no longer exists (you have to use TestCase class from the PHPUnit\Framework namespace instead).

Example Usage

n/a

Checklist

  • Updated CHANGELOG.md to describe BC breaks / deprecations | new feature | bugfix
  • Documentation pull request created (if not simply a bugfix)
  • update FeatureTestListener

To Do

  • update changelog

@sagikazarmark
Copy link
Member

Cool, thanks

@sagikazarmark sagikazarmark merged commit 10484ce into php-http:master Mar 17, 2017
@xabbuh
Copy link
Member Author

xabbuh commented Mar 17, 2017

@sagikazarmark Thanks for merging, but actually the FeatureTestListener is currently missing the update (sorry I should have make that more clear).

@xabbuh xabbuh deleted the phpunit6-compat branch March 17, 2017 11:00
@sagikazarmark
Copy link
Member

No problem, I will update that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants