-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Puli Factory is not available #38
Comments
For the time being you need to install puli/cli. Either the PHAR in your prefix or the package in your application. This should change soon and discovery will require puli/cli. |
See #39 |
this is fixed if you require |
Thank you for the quick answer. However I'm now getting this error:
From the message I assume I have to install Thank you, |
Try installing 0.6.2 discovery (version override should work with the linkedin client. @Nyholm could update the required discovery version) |
You have to install php-http/message to use Guzzle or Diactoros factories and the chosen message implementation package. |
if i am not mistaken, requiring one of the adapters in your project is enough. |
Oh ok strange, I already had the Thanks for the help! |
I think message should not be a dependency of guzzle6 adapter. The library doesn't need it internally. If you want to use message factories in your application, you need to install the dependencies. Discovery can be a dependency, where the client needs to discover a message factory, but implementations should still be installed manually. |
okay. i think we still need to work on the documentation to make it easily understandable what you need to require in which situation. and @Nyholm will need to update his documentation or add something to the changelog, if its not already there. @sagikazarmark if discovery is mainly for zero-config clients, would it make sense to have it require message? or should a library that uses the message factories do that itself? the later probably makes most sense. http://docs.httplug.io/en/latest/httplug/library-developers.html#messages should elaborate a bit more |
By default, message provides some message factories. In a DI context you need to configure them and inject to the class using it. Discovery provides a zero-config way to find any installed message factories. Also, discovery is most likely used by your library, while the implementation should be installed in the application. Yes, we need better documentation for that. |
Per the docs... I ran this command and produced the following error.
|
How is your problem related to this issue? Per what docs? HTTPlug is already stable, the referred package requires it, so I wonder where you found such an installation command. |
I'm using php-http/discovery: 1.4.0 and getting this error 😞 |
@sagikazarmark this was a while back, it looks like things are fixed now. My fault for not posting the link to the docs 😖 it was somewhere in here: http://docs.php-http.org/en/latest/index.html you can disregard my previous comment. I'm no longer using this lib. |
Hello,
I'm using the
Happyr/LinkedIn-API-client
package, which has recently been updated to use PSR-7.Since the update I'm getting the following error:
This happens in the
ClassDiscovery
class ongetPuliFactory
method.When going to https://github.com/puli/factory, I see it's not maintained anymore.
Anything I missed ?
The text was updated successfully, but these errors were encountered: