require puli cli to work out of the box #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
👍 |
sagikazarmark
added a commit
that referenced
this pull request
Jan 4, 2016
require puli cli to work out of the box
|
I agree with this merge, but I want to state the implications of this. Since Puli/cli has dependencies on symfony/components: ~2.3 we can not use discovery in a Symfony 3.0 application. |
|
Should be fixed in a future version. Any suggestions? |
|
@ddroer yeah they just merged my PR. Yes. All dependencies must be stable until we can tag a stable release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as per the discussion in https://github.com/FriendsOfSymfony/FOSHttpCache/pull/257/files#r48696611
for discovery to work, we need puli. discovery is all about ease of use, mostly a first impression thing (to properly configure your client, you want to instantiate/configure the client yourself). the first impression should be as smooth as possible. puli can't be expected to be globally installed in most systems. the worst that can happen here is that we unnecessarily install the puli cli in vendor. that seems pretty acceptable as worst case...