get rid of more dangerous ssl settings in examples. #217

php-http · Dec 28, 2017 · da5eb18 · da5eb18
1 parent 4150a00
commit da5eb18
Show file tree

Hide file tree

Showing 4 changed files with 2 additions and 6 deletions.
diff --git a/clients/curl-client.rst b/clients/curl-client.rst
@@ -48,7 +48,6 @@ You can use `cURL options <http://php.net/curl_setopt>`_ to configure Client::
 
     $options = [
         CURLOPT_CONNECTTIMEOUT => 10, // The number of seconds to wait while trying to connect.
-        CURLOPT_SSL_VERIFYPEER => false // Stop cURL from verifying the peer's certificate
     ];
     $client = new Client(MessageFactoryDiscovery::find(), StreamFactoryDiscovery::find(), $options);
 

diff --git a/clients/guzzle6-adapter.rst b/clients/guzzle6-adapter.rst
@@ -22,7 +22,6 @@ to the client::
     use Http\Adapter\Guzzle6\Client as GuzzleAdapter;
 
     $config = [
-        'verify' => false,
         'timeout' => 2,
         'handler' => //...
         // ...
@@ -37,7 +36,7 @@ to the client::
         use GuzzleHttp\Client as GuzzleClient;
         use Http\Adapter\Guzzle6\Client as GuzzleAdapter;
 
-        $config = ['verify' => false ];
+        $config = ['timeout' => 5];
         // ...
         $guzzle = new GuzzleClient($config);
         // ...

diff --git a/integrations/symfony-bundle.rst b/integrations/symfony-bundle.rst
@@ -61,7 +61,6 @@ Usage
                 factory: 'httplug.factory.guzzle6'
                 plugins: ['httplug.plugin.logger']
                 config:
-                    verify: false
                     timeout: 2
 
 .. code-block:: php
@@ -177,7 +176,7 @@ services.
                 config:
                     # These options are given to Guzzle without validation.
                     defaults:
-                        verify_ssl: false
+                        # timeout if connection is not established after 4 seconds
                         timeout: 4
             acme:
                 factory: 'httplug.factory.curl'

diff --git a/integrations/symfony-full-configuration.rst b/integrations/symfony-full-configuration.rst
@@ -75,7 +75,6 @@ This page shows an example of all configuration values provided by the bundle.
                 http_methods_client: false  # Can only be true if flexible_client is false
                 config:
                     # Options to the Guzzle 6 constructor
-                    verify: false
                     timeout: 2
                 plugins:
                     # Can reference a globally configured plugin service