Skip to content
This repository has been archived by the owner on Jan 6, 2024. It is now read-only.

PHP 8 support #82

Closed
stof opened this issue Jan 21, 2021 · 6 comments
Closed

PHP 8 support #82

stof opened this issue Jan 21, 2021 · 6 comments

Comments

@stof
Copy link

stof commented Jan 21, 2021

Description

It would be great if this adapter could support PHP 8. Guzzle 6 allows it in composer.json
@xabbuh
Copy link
Member

xabbuh commented Jan 21, 2021

There was an earlier attempt in #76.

@stof
Copy link
Author

stof commented Jan 21, 2021

I'm closing this as guzzle7-adapter supports PHP 8 and after investigation, the only package forcing me to use guzzle 6 rather than guzzle 7 in my project was this guzzle6-adapter.

@stof stof closed this as completed Jan 21, 2021
@dbu
Copy link
Contributor

dbu commented Jan 21, 2021

also, guzzle 6 has a bad composer.json with >= xy instead of defining its tested range. and it actually does not work on php 8 afaik.

@jorissteyn jorissteyn mentioned this issue Jan 31, 2021
Closed
@GrahamCampbell
Copy link
Contributor

👎 for allowing this. People and ignore the PHP req or upgrade.

@dbu
Copy link
Contributor

dbu commented Mar 2, 2021

see #83 and #86 for further discussion

@GrahamCampbell
Copy link
Contributor

I still disagree with adding PHP 8 here.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@dbu @stof @xabbuh @GrahamCampbell