This repository has been archived by the owner on Jan 6, 2024. It is now read-only.
add support for php 8 #76
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
dmaicher
force-pushed
the
php_8
branch
6 times, most recently
from
1a4c47c
to
e31c0f0
Compare
|
The PrettyCI fail seems unrelated? |
|
Actually nevermind. The Guzzle7 adapter supports PHP 8 already. If this is still relevant let me know. |
|
yeah, i'd not use guzzle 6 on php 8. the composer file has the bold statement that it supports every future php version but the last build in juli failed: https://travis-ci.org/github/guzzle/guzzle/jobs/704216007 i guess guzzle 6 is kind of end of life anyways, guzzle 7 has been around for a while. |
Closed
|
ftr: see #86 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
PHP 8 will be released soon. So it would be nice to add support for it.
Checklist