This repository has been archived by the owner on Jan 6, 2024. It is now read-only.
Add default empty config value for Client::buildClient #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is an issue when we create new Client object with no parameters: constructor calls Client::buildClient method without params too, and it fails because it has one required parameter. It may be walked around by using Client::createWithConfig method with an empty config, but it will be cool if it will work natural way with constructor too
|
uups. sorry, thanks for spotting. i fixed this in 594cd47 (cs says to use i will release 1.1.1 as soon as i see the build running through. |
|
Good catch, thanks and sorry for the trouble. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an issue when we create new Client object with no parameters: constructor calls Client::buildClient method without params too, and it fails because it has one required parameter. It may be walked around by using Client::createWithConfig method with an empty config, but it will be cool if it will work natural way with constructor too