-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make adapters PSR-7 compliant #29
Comments
It is definitely relevant as it contains some changes that needs to be backported. Also, the separation itself is step one to remove the internal request thing from the adapters. |
Okay, so let’s first get the internal_separation branches merged, and then continue with cleaning up the adapter interfaces. |
Yeah. |
I am planning to merge those branches by the end of the week. |
Cool! Let me know when you have done that. I’ll write a PR after that to clean up the Adapter interfaces with the Guzzle 6 adapter as a (very simple) testcase. |
As discussed in php-http/guzzle6-adapter#1: there should only be only one adapter interface and that will take PSR-7 request objects and return PSR-7 response objects. So we need to:
get()
/post()
etc.).If we follow this road, are the internal_separation still relevant? Or can we start work on this right away?
The text was updated successfully, but these errors were encountered: