Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make adapters PSR-7 compliant #29

Closed
ddeboer opened this issue May 27, 2015 · 5 comments
Closed

Make adapters PSR-7 compliant #29

ddeboer opened this issue May 27, 2015 · 5 comments

Comments

@ddeboer
Copy link
Contributor

ddeboer commented May 27, 2015

As discussed in php-http/guzzle6-adapter#1: there should only be only one adapter interface and that will take PSR-7 request objects and return PSR-7 response objects. So we need to:

  • remove the HttpAdapter
  • rename PsrHttpAdapter to HttpAdapter(?)
  • create a separate client package that will contain the convenience methods currently in HttpAdapter (get()/post() etc.).

If we follow this road, are the internal_separation still relevant? Or can we start work on this right away?

@sagikazarmark
Copy link
Member

It is definitely relevant as it contains some changes that needs to be backported. Also, the separation itself is step one to remove the internal request thing from the adapters.

@ddeboer
Copy link
Contributor Author

ddeboer commented May 27, 2015

Okay, so let’s first get the internal_separation branches merged, and then continue with cleaning up the adapter interfaces.

@sagikazarmark
Copy link
Member

Yeah.

@sagikazarmark
Copy link
Member

I am planning to merge those branches by the end of the week.

@ddeboer
Copy link
Contributor Author

ddeboer commented May 27, 2015

Cool! Let me know when you have done that. I’ll write a PR after that to clean up the Adapter interfaces with the Guzzle 6 adapter as a (very simple) testcase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants