Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Virtual packages #55

Closed
sagikazarmark opened this issue Sep 25, 2015 · 6 comments · Fixed by php-http/documentation#10
Closed

Virtual packages #55

sagikazarmark opened this issue Sep 25, 2015 · 6 comments · Fixed by php-http/documentation#10

Comments

@sagikazarmark
Copy link
Member

Currently we have adapter-implementation virtual package which could be renamed to client-implementation, however we now have three interfaces.

Possible virtual packages:

  • php-http/psr-client-implementation
  • php-http/methods-client-implementation
  • php-http/client-implementation
@dbu
Copy link
Contributor

dbu commented Sep 25, 2015

i think psr-client-implementation and methods-... are enough. not sure how much sense it makes to combine the two concepts and have one library consume the unified interface.

or we could only have client-implementation and provide two classes in the utils repo that are client-implementation that can be set up with either type of client to add the other part. then you would always use a client that can do both concepts.

@sagikazarmark
Copy link
Member Author

The HttpClient exception only exists to ease type-hinting when both the interfaces are needed. I also think that the two are enough for dependency handling.

@sagikazarmark sagikazarmark mentioned this issue Oct 21, 2015
Closed
@sagikazarmark
Copy link
Member Author

Is it php-http/client-implementation then?

@dbu
Copy link
Contributor

dbu commented Oct 21, 2015

👍

we mainly need to adjust the existing adapters and the doc for this, right?

@sagikazarmark
Copy link
Member Author

Yes.

@dbu dbu mentioned this issue Oct 23, 2015
Merged
@sagikazarmark
Copy link
Member Author

php-http/client-implementation

Nyholm added a commit to Nyholm/httplug that referenced this issue Dec 26, 2019
@Nyholm
Merge pull request php-http#55 from php-http/httplug_factory
453e59c 
[WIP] Remove discovery dependency
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

reorganizing the documentation php-http/documentation
2 participants
@dbu @sagikazarmark