Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename HttpAsyncClient to AsyncHttpClient #84

Closed
sagikazarmark opened this issue Nov 16, 2015 · 4 comments
Closed

Rename HttpAsyncClient to AsyncHttpClient #84

sagikazarmark opened this issue Nov 16, 2015 · 4 comments

Comments

@sagikazarmark
Copy link
Member

Name seems to be more logical this way.

Ping @joelwurtz @dbu
@sagikazarmark
Copy link
Member Author

On the other hand many things rely on it already, but if we want to change it, we should do it now.

@joelwurtz
Copy link
Member

really don't mind, both seems ok to me so a +0 for me

@sagikazarmark
Copy link
Member Author

Ok, we sticked to HttpPsrClient and HttpMethodsClient earlier anyway, so we can leave it as is.

@dbu
Copy link
Contributor

dbu commented Nov 16, 2015

agreed. lets leave it as is. its just a name ;-)

@dbu dbu closed this as completed Nov 16, 2015
Nyholm pushed a commit to Nyholm/httplug that referenced this issue Dec 26, 2019
@dbu
Merge pull request php-http#84 from php-http/dev-improved-collector
68ccd1e 
Improved collector and debug toolbar output
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dbu @joelwurtz @sagikazarmark