Remove exception docblock

[gmponos]

I think according to PSR this exception should not be thrown... :/

[dbu]

correct. looking at the psr-18 ClientInterface that we extend here, i think we should actually drop all code in here and make this

/**
 * {@inheritdoc}
 * 
 * Provide the Httplug HttpClient interface for BC. You should typehint Psr\Http\Client\ClientInterface in new code
 */
interface HttpClient extends ClientInterface
{
}

the method definition is a copy of the psr method and therefore does nothing. do you want to adjust this accordingly?

[gmponos]

do you want to adjust this accordingly?

Done.. check again :)

[dbu]

@Nyholm am i missing something or is this what the interface should look like now?

[Nyholm]

Nope, We still throw HTTPlug exceptions. The exceptions however extends PSR18.

Im 👎

[gmponos]

Hmm.. I missed that.. @Nyholm is correct... So shall I revert here before @dbu comment...

are you all good with this?

[Nyholm]

To remove \Exception and update the description on the other line makes sense, yes.

[dbu]

We still throw HTTPlug exceptions. The exceptions however extends PSR18.

is there any value in explicitly stating that, however? imho people should be using the PSR-18 exception interfaces, not the ones from the HTTPlug BC layer. as the exceptions extend the PSR-18 interface, the phpdoc of the base interface is not wrong.

[Nyholm]

If you are using a HTTPlug 2.0 client you may catch both HTTPlug exceptions and PSR18 exceptions.

imho people should be using the PSR-18 exception interfaces
Sure, and they may.

[dbu]

@Nyholm so you would say we should add the method signature again to add the phpdoc for the httplug exceptions?

[joelwurtz]

If you are using a HTTPlug 2.0 client you may catch both HTTPlug exceptions and PSR18 exceptions.

I don't agree with that, catching an HTTPlug is now a detail of implementation in 2.0, and we should not spec this, as this will allow people to correctly depend on PSR 18 and completly remove our interface latter.

[dbu]

@Nyholm are you okay to merge with this or do you disagree with the last comments from joel and me?