Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better log display #2

Merged
merged 1 commit into from Nov 23, 2017
Merged

Better log display #2

merged 1 commit into from Nov 23, 2017

Conversation

lyrixx
Copy link
Contributor

@lyrixx lyrixx commented Nov 22, 2017

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Related tickets
Documentation
License MIT

As the logger inlines HTTP request / response, it's really more readable
if the message use many lines by default.

As the logger inlines HTTP request / response, it's really more readable
if the message use many lines by default.
@dbu
Copy link
Contributor

dbu commented Nov 22, 2017

what is the visual impact of this? does it not waste too much space in the collapsed view of the request list? if you think its good there, i am all for doing it, seems the way one usually reads HTTP, with newlines to separate parts

@lyrixx
Copy link
Contributor Author

lyrixx commented Nov 23, 2017

@dbu It is really really cleaner ;)

With bin/console server:log -vvv --format="%datetime% %start_tag%%level_name%%end_tag% <comment>[%channel%]</> %message%\n" (I don't want to see extra & context, it already in the log message):

before:
image

after:
image

@dbu dbu merged commit 6715e4a into php-http:master Nov 23, 2017
@dbu
Copy link
Contributor

dbu commented Nov 23, 2017

indeed. thanks a lot!

@lyrixx lyrixx deleted the better-logs branch November 24, 2017 00:35
@Nyholm
Copy link
Member

Nyholm commented Nov 24, 2017

Thank you for the images!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants