Skip specific tests on HHVM instead of allowing to fail, see #6

php-http · Dec 21, 2015 · 7f7dd42 · 7f7dd42
1 parent c7fcd53
commit 7f7dd42
Show file tree

Hide file tree

Showing 7 changed files with 30 additions and 2 deletions.
diff --git a/.travis.yml b/.travis.yml
@@ -22,8 +22,6 @@ branches:
         - /^analysis-.*$/
 
 matrix:
-    allow_failures:
-        - php: hhvm
     fast_finish: true
     include:
         - php: 5.4

diff --git a/spec/Encoding/ChunkStreamSpec.php b/spec/Encoding/ChunkStreamSpec.php
@@ -3,12 +3,17 @@
 namespace spec\Http\Message\Encoding;
 
 use Psr\Http\Message\StreamInterface;
+use PhpSpec\Exception\Example\SkippingException;
 use PhpSpec\ObjectBehavior;
 
 class ChunkStreamSpec extends ObjectBehavior
 {
     function let(StreamInterface $stream)
     {
+        if (defined('HHVM_VERSION')) {
+            throw new SkippingException('Skipping test as there is no dechunk filter on hhvm');
+        }
+
         $this->beConstructedWith($stream);
     }
 

diff --git a/spec/Encoding/CompressStreamSpec.php b/spec/Encoding/CompressStreamSpec.php
@@ -3,12 +3,17 @@
 namespace spec\Http\Message\Encoding;
 
 use Psr\Http\Message\StreamInterface;
+use PhpSpec\Exception\Example\SkippingException;
 use PhpSpec\ObjectBehavior;
 
 class CompressStreamSpec extends ObjectBehavior
 {
     function let(StreamInterface $stream)
     {
+        if (defined('HHVM_VERSION')) {
+            throw new SkippingException('Skipping test as zlib is not working on hhvm');
+        }
+
         $this->beConstructedWith($stream);
     }
 

diff --git a/spec/Encoding/DechunkStreamSpec.php b/spec/Encoding/DechunkStreamSpec.php
@@ -3,12 +3,17 @@
 namespace spec\Http\Message\Encoding;
 
 use Psr\Http\Message\StreamInterface;
+use PhpSpec\Exception\Example\SkippingException;
 use PhpSpec\ObjectBehavior;
 
 class DechunkStreamSpec extends ObjectBehavior
 {
     function let(StreamInterface $stream)
     {
+        if (defined('HHVM_VERSION')) {
+            throw new SkippingException('Skipping test as there is no dechunk filter on hhvm');
+        }
+
         $this->beConstructedWith($stream);
     }
 

diff --git a/spec/Encoding/DecompressStreamSpec.php b/spec/Encoding/DecompressStreamSpec.php
@@ -3,12 +3,17 @@
 namespace spec\Http\Message\Encoding;
 
 use Psr\Http\Message\StreamInterface;
+use PhpSpec\Exception\Example\SkippingException;
 use PhpSpec\ObjectBehavior;
 
 class DecompressStreamSpec extends ObjectBehavior
 {
     function let(StreamInterface $stream)
     {
+        if (defined('HHVM_VERSION')) {
+            throw new SkippingException('Skipping test as zlib is not working on hhvm');
+        }
+
         $this->beConstructedWith($stream);
     }
 

diff --git a/spec/Encoding/GzipDecodeStreamSpec.php b/spec/Encoding/GzipDecodeStreamSpec.php
@@ -3,12 +3,17 @@
 namespace spec\Http\Message\Encoding;
 
 use Psr\Http\Message\StreamInterface;
+use PhpSpec\Exception\Example\SkippingException;
 use PhpSpec\ObjectBehavior;
 
 class GzipDecodeStreamSpec extends ObjectBehavior
 {
     function let(StreamInterface $stream)
     {
+        if (defined('HHVM_VERSION')) {
+            throw new SkippingException('Skipping test as zlib is not working on hhvm');
+        }
+
         $this->beConstructedWith($stream);
     }
 

diff --git a/spec/Encoding/GzipEncodeStreamSpec.php b/spec/Encoding/GzipEncodeStreamSpec.php
@@ -3,12 +3,17 @@
 namespace spec\Http\Message\Encoding;
 
 use Psr\Http\Message\StreamInterface;
+use PhpSpec\Exception\Example\SkippingException;
 use PhpSpec\ObjectBehavior;
 
 class GzipEncodeStreamSpec extends ObjectBehavior
 {
     function let(StreamInterface $stream)
     {
+        if (defined('HHVM_VERSION')) {
+            throw new SkippingException('Skipping test as zlib is not working on hhvm');
+        }
+
         $this->beConstructedWith($stream);
     }