Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP 8.0 Support #129

Merged
merged 1 commit into from
Nov 11, 2020
Merged

PHP 8.0 Support #129

merged 1 commit into from
Nov 11, 2020

Conversation

GrahamCampbell
Copy link
Contributor

@GrahamCampbell GrahamCampbell commented Jul 13, 2020 •
edited

Q A
Bug fix? yes
New feature? yes
BC breaks? no
Deprecations? no
License MIT

@GrahamCampbell GrahamCampbell marked this pull request as draft July 13, 2020 12:00
@ausi ausi mentioned this pull request Sep 10, 2020
Closed
42 tasks
@GrahamCampbell GrahamCampbell marked this pull request as ready for review November 10, 2020 19:36
@GrahamCampbell
Copy link
Contributor Author

Finally got this to work! // cc @dbu

@dbu
Copy link
Contributor

dbu commented Nov 11, 2020 •
edited

great! any idea why the "builds" still say "waiting for status to be reported"?

@GrahamCampbell
Copy link
Contributor Author

Because someone has added builds with different names as required in the protected branch settings.

@dbu dbu merged commit 9e94a9f into php-http:master Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbu dbu dbu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@GrahamCampbell @dbu