Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare for 1.6 #79

Merged
merged 2 commits into from Jul 5, 2017
Merged

Prepare for 1.6 #79

merged 2 commits into from Jul 5, 2017

Conversation

Nyholm
Copy link
Member

@Nyholm Nyholm commented Jun 23, 2017

No description provided.

@Nyholm Nyholm requested a review from dbu June 23, 2017 07:38
@dbu
Copy link
Contributor

dbu commented Jun 23, 2017

would love if we could solve #78 before tagging 1.6 - lets give it another day or so but then proceed with the release to not block progress :-)

@Nyholm
Copy link
Member Author

Nyholm commented Jul 2, 2017

Currently waiting for clue/stream-filter#15 to be merged and released.

@Nyholm
Copy link
Member Author

Nyholm commented Jul 5, 2017

Or should we wait for clue/php-stream-filter? Would we update our composer.json? clue/php-stream-filter is only going to release a patch.

I think we should release 1.6 now.

dbu
dbu approved these changes Jul 5, 2017
View reviewed changes
Copy link
Contributor

@dbu dbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't think the clue patch is a blocker for a release. things will "just start to work" with clue once they release the fix.

@Nyholm Nyholm merged commit 2edd63b into master Jul 5, 2017
@Nyholm Nyholm deleted the Nyholm-patch-1 branch July 5, 2017 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbu dbu dbu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Nyholm @dbu