Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add query param authentication #9

Merged
merged 1 commit into from Dec 22, 2015
Merged

Add query param authentication #9

merged 1 commit into from Dec 22, 2015

Conversation

sagikazarmark
Copy link
Member

No description provided.

@dbu
Copy link
Contributor

dbu commented Dec 22, 2015

does this exist? it sounds like a rather dangerous way of doing things. if its ever done with a browser, it ends up in the history, and could even be spilled as a referrer. i would expect to use a post body in that case.

that said, if there are systems out there doing this, we can have it but i would like to have a little bit more documentation that warns that this is not a good idea in general.

@sagikazarmark
Copy link
Member Author

Unfortunately, this exists. Not just sort of acceptable solutions (like some request token), but user/password pairs as well (just did it connecting to a third party API, so from my point of view I need this feature, their security sucks 😜 )

@dbu
Copy link
Contributor

dbu commented Dec 22, 2015 via email

@sagikazarmark
Copy link
Member Author

Sure, will also add it to the documentation (php-http/documentation#43)

@sagikazarmark
Copy link
Member Author

@dbu is it better this way? I will also place a big fat warning in the docs.

Add warning about QueryParam auth: it is not recommended
sagikazarmark added a commit that referenced this pull request Dec 22, 2015
Add query param authentication
@sagikazarmark sagikazarmark merged commit 8a29f85 into master Dec 22, 2015
@sagikazarmark sagikazarmark deleted the query_param_auth branch December 22, 2015 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants