-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explicit type declarations is not handled! #24
Comments
Heya, thanks for the report. Absolutely correct, i'll look into it ✌️ |
…t type declaration first
Many thanks, i made small adjustments and also opened #26 for the next major, since i never liked that class to begin with 😄 |
Thank you very much! Could you please release a new version to do not hack that in my application? |
Sure thing, i am on it, i need to fix the stan error, so i already merged your changes ✌️ |
* #24 For PHP version >= 7.4.0 look for the properties explicit type declaration first (#25) * #24 For PHP version >= 7.4.0 look for the properties explicit type declaration first * Apply suggestions from code review Co-authored-by: Pavel Alexeev <Pavel_Alexeev@epam.com> Co-authored-by: Nick <nickjobszh@gmail.com> * fix stan (#27) * fix import Co-authored-by: Pavel Alexeev aka Pahan-Hubbitus <pahan@hubbitus.info> Co-authored-by: Pavel Alexeev <Pavel_Alexeev@epam.com>
* #24 For PHP version >= 7.4.0 look for the properties explicit type declaration first (#25) * #24 For PHP version >= 7.4.0 look for the properties explicit type declaration first * Apply suggestions from code review Co-authored-by: Pavel Alexeev <Pavel_Alexeev@epam.com> Co-authored-by: Nick <nickjobszh@gmail.com> * fix stan (#27) * fix import Co-authored-by: Pavel Alexeev aka Pahan-Hubbitus <pahan@hubbitus.info> Co-authored-by: Pavel Alexeev <Pavel_Alexeev@epam.com>
Since PHP 7.4 type declarations were introduced.
But php-avro-schema-generator does not look in it.
Steps to reproduce:
Actual behavior
Despite explicit type declaration:
Script outputs:
Expected behavior
The text was updated successfully, but these errors were encountered: