ParserClass do not resolve parent classes without use statements

[Hubbitus]

$registry = (new ClassRegistry($converter))
            ->addClassDirectory($this->projectDir . '/vendor/pimcore/pimcore/lib/Loader/')
                ->load();

And I have got error:

In ClassParser.php line 197:                                                  
  Class "AbstractClassNameLoader" does not exist  

Problem happened on class declaration starting from:

<?php

declare(strict_types = 1);

namespace Pimcore\Loader\ImplementationLoader;

class ClassMapLoader extends AbstractClassNameLoader
{
...

Class AbstractClassNameLoader indeed did not listed in the use statements, but that present in the same namespace and directory.

[Hubbitus]

At master branch 32d5b78

[Hubbitus]

Please wait and do not merge request!

[Hubbitus]

Situation became even worst, please look at the class Pimcore\Model\Listing\Dao\AbstractDao:

<?php

namespace Pimcore\Model\Listing\Dao;

use Pimcore\Model;

abstract class AbstractDao extends Model\Dao\AbstractDao
{

There use Pimcore\Model; is not class use, but namespace! And class extend the same-named class from another namespace!

So, I see only single robust solution to resolve all such cases - use reflection instead of parsing...

[nick-zh]

Good find, i agree, this is probably the best way to go 👍

[Hubbitus]

Meantime that may be slow sometimes...

[nick-zh]

I think that's an acceptable trade off, since this is not something that needs to be super fast but accurate. Impact should be negligible 😁