Fixed getServerByKey function #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
November 10, 2012 22:30
…st instead of memcached_server_st. The structures were compatible to eachother, but this recently changed between 1.0.5 and 1.0.13. See https://bugs.launchpad.net/libmemcached/+bug/1076048 for more info.
…server environment: getLastErrorMessage() getLastErrorCode() getLastErrorErrno() getLastDisconnectedServer()
…T' (new in 1.0.3)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The underlying function memcached_server_by_key returns a memcached_server_instance_st instead of memcached_server_st. The structures were compatible to each other, but this
recently changed between 1.0.5 and 1.0.13. This made this function failing.
See https://bugs.launchpad.net/libmemcached/+bug/1076048 for more info.
By using the proper function calls they work again, but unfortunately there's no fix for the weight. I think it's useless to return the weight, since you can know it from php-user-land (it's passed to either addServer or addServers). I suggest to remove the weight as a return type, but I didn't want to break anyone's code.