Fixed tests after chanage to php_memc_do_serverlist_callback() #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The php function getServerList() no longer returns a weight value. The tests have been updated to reflect this change. The need for this change is result of commenting out "add_assoc_long(array, "weight", instance->weight);" in php_memcached.c
|
I fixed these manually, didnt notice the PR. Thanks anyway! |
fwolf
added a commit
to fwolf/fwlib
that referenced
this pull request
Nov 12, 2014
Memcached::getServerList() result may not contains 'weight', see @link php-memcached-dev/php-memcached#56
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The php function getServerList() no longer returns a weight value. The tests have been updated to reflect this change.
The need for this change is result of commenting out "add_assoc_long(array, "weight", instance->weight);" in php_memcached.c