Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy editing suggestions in README #100

Merged
merged 2 commits into from
Aug 9, 2016

Conversation

eryno
Copy link
Contributor

@eryno eryno commented Jul 20, 2016

I meant to get to this sooner, but I hope it's still useful. Please review that everything I've written is correct, because I had to make some guesses about what you meant. Especially the "Why" section (which is the most important section to get right!).

I meant to get to this sooner, but I hope it's still useful. Please review that everything I've written is correct, because I had to make some guesses about what you meant. Especially the "Why" section (which is the most important section to get right!).
@coveralls
Copy link

coveralls commented Jul 20, 2016

Coverage Status

Coverage remained the same at 97.842% when pulling a9768c2 on eryno:patch-1 into da11a51 on php-mime-mail-parser:master.

@eXorus
Copy link
Member

eXorus commented Jul 21, 2016

Thanks a lot.
One things seems to be wrong : Create and send webmail

It's possible to create an webmail I do that but what do you mean by send ?

@eryno
Copy link
Contributor Author

eryno commented Jul 21, 2016

@noobiwan: Good catch, mistype on my part.

@eXorus: I was trying to reword "-If you need to parse and read email from server like postfix. You can also create a webmail and insert into your database emails with all information like subject, html body, attachments, ...", and I assumed that "create a webmail" meant "send email", but it looks like I was wrong.

Can you explain what you mean by "create a webmail"? I've only seen "webmail" used to describe a web interface for accessing POP3 or IMAP mails. I don't understand it in this context.

@coveralls
Copy link

coveralls commented Jul 21, 2016

Coverage Status

Coverage remained the same at 97.842% when pulling 39e3b58 on eryno:patch-1 into da11a51 on php-mime-mail-parser:master.

@luiz-brandao
Copy link
Contributor

@eryno what @eXorus probably meant is that this library is just for reading/parsing email and not for sending. Yes you can send email in a webmail but you would need another component for that.

@eryno
Copy link
Contributor Author

eryno commented Jul 21, 2016

@LeWiZ: Ah, I think I follow now. Thanks for the clarification. I'll clean
that part up.

On Jul 21, 2016 5:49 PM, "Lewiz" notifications@github.com wrote:

@eryno https://github.com/eryno what @eXorus https://github.com/eXorus
probably meant is that this library is just for reading/parsing email and
not for sending. Yes you can send email in a webmail but you would need
another component for that.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#100 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAqMc2nX0diE8CPvmflp0H0mg4IaSIQEks5qX_dkgaJpZM4JRMTp
.

@eXorus eXorus merged commit af89647 into php-mime-mail-parser:master Aug 9, 2016
@eXorus
Copy link
Member

eXorus commented Aug 9, 2016

Thanks @eryno and @noobiwan

@eryno eryno deleted the patch-1 branch August 9, 2016 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants