Added option to include/exclude inline attachments #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nitpick-CI
reviewed
Nov 17, 2016
| @@ -389,16 +389,19 @@ public function getAddresses($name) | |||
| * | |||
| * @return Attachment[] | |||
| */ | |||
| public function getAttachments() | |||
| public function getAttachments($include_inline=false) | |||
There was a problem hiding this comment.
- Incorrect spacing between argument
$include_inlineand equals sign; expected 1 but found 0 - Incorrect spacing between default value and equals sign for argument
$include_inline; expected 1 but found 0
Nitpick-CI
reviewed
Nov 17, 2016
| @@ -448,9 +451,9 @@ public function getAttachments() | |||
| * @return array Saved attachments paths | |||
| * @throws Exception | |||
| */ | |||
| public function saveAttachments($attach_dir) | |||
| public function saveAttachments($attach_dir,$include_inline=false) | |||
There was a problem hiding this comment.
- Incorrect spacing between argument
$include_inlineand equals sign; expected 1 but found 0 - Incorrect spacing between default value and equals sign for argument
$include_inline; expected 1 but found 0 - Expected 1 space between comma and argument
$include_inline; 0 found
1 similar comment
|
I changed the default for |
|
Thanks a lot it's a very good job. But we are missing some test about include inline attachments to false |
1 similar comment
|
Tell me what you think of the new unit test. It processes all the sample message again but with $include_inline set to false. |
|
It will be fine like this for the moment. Thanks. I really need to work on a new version 3.0 with better improvement and better structure for test and parser. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an optional argument to getAttachments and saveAttachments to include inline attachments (defaults to false). Also update the README file accordingly.