Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

leave inline disposition as inline #409

Merged
merged 1 commit into from
Jan 17, 2023

Conversation

m42e
Copy link
Contributor

@m42e m42e commented Jan 6, 2023

Content disposition of inline is changed. I could not figure out any reason to overwrite inline disposition with attachment.
It is causing issues in AnonAddy, when the message is forwarded as it destroys the references in the mail body.

@codecov-commenter
Copy link

Codecov Report

Base: 97.03% // Head: 97.00% // Decreases project coverage by -0.03% ⚠️

Coverage data is based on head (f970f23) compared to base (65c7e61).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #409      +/-   ##
============================================
- Coverage     97.03%   97.00%   -0.04%     
- Complexity      176      177       +1     
============================================
  Files             6        6              
  Lines           439      468      +29     
============================================
+ Hits            426      454      +28     
- Misses           13       14       +1     
Impacted Files Coverage Δ
src/Parser.php 95.75% <100.00%> (-0.03%) ⬇️
src/Charset.php 100.00% <0.00%> (ø)
src/Attachment.php 100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@eXorus eXorus merged commit 4c84ce8 into php-mime-mail-parser:main Jan 17, 2023
@willbrowningme
Copy link

Hi @eXorus, would it be possible to create a new minor release that includes this PR?

Many thanks,
Will

@eXorus
Copy link
Member

eXorus commented Jun 26, 2023

Hello @willbrowningme

I apologize, I completely forgot to make the release. Thank you for the reminder. I'm a bit overwhelmed at the moment, so I haven't been able to dedicate as much time as I would like to php-mime-mail-parser.

Released in 8.0.1.

@willbrowningme
Copy link

Thanks very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants