Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating README & Removing global namespace option. #69

Closed
wants to merge 1 commit into from

Conversation

sketchthat
Copy link

Updating README documentation to include required parameter of $url in Parser saveAttachments function.

Removing global namespace from Parser.php as it wasn't consistent with the rest of the function calls & isn't needed.

… on other functions. Updating README to include required in saveAttachments function.
@sketchthat sketchthat changed the title Removing global namespace from Parser as it is unnecessary & not used… Updating README & Removing global namespace option. Nov 27, 2015
@eXorus
Copy link
Member

eXorus commented Dec 2, 2015

Hello,

Where do you see that saveAttachments required URL ?

public function saveAttachments($attach_dir)

@sketchthat
Copy link
Author

I grabbed the package through composer and it looks like it has a different version.

public function saveAttachments($attach_dir, $url)

Ignore my pull request, it isn't relevant in this version.

@sketchthat sketchthat closed this Dec 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants