Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Concurrent Requests #268

Closed
kelunik opened this issue Sep 5, 2017 · 5 comments
Closed

Concurrent Requests #268

kelunik opened this issue Sep 5, 2017 · 5 comments

Comments

@kelunik
Copy link
Contributor

kelunik commented Sep 5, 2017

Currently there's a concurrent request feature, which kind of application really uses that? IMO applications that are able to concurrently process requests should directly use either react/http or amphp/aerys, but do not benefit from php-pm/php-pm.

Should #267 be accepted, can we then remove that?

@marcj
Copy link
Member

marcj commented Sep 5, 2017

Yes, we can probably remove that as it causes only issues.

@andig
Copy link
Contributor

andig commented Sep 5, 2017

IMO applications that are able to concurrently process requests should directly use either react/http or amphp/aerys, but do not benefit from php-pm/php-pm.

I beg to differ. Any application that uses request/ response abstraction and does internally not rely on state should be able to work with concurrent requests. One such example should be the volkszaehler middleware (https://github.com/volkszaehler/volkszaehler.org/blob/master/lib/Router.php) although it's not based on reactPHP.

@kelunik
Copy link
Contributor Author

kelunik commented Sep 5, 2017

@andig Seems like that does blocking dispatching and thus can't support concurrent requests?

@andig
Copy link
Contributor

andig commented Nov 30, 2017

See #302 for removing concurrent request support.

@andig
Copy link
Contributor

andig commented Nov 30, 2017

Seems like that does blocking dispatching and thus can't support concurrent requests?

@kelunik that is ... of course true. PR for removal is available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants