Merge pull request #212 from php-school/private-style

Make style props private
php-school · Dec 20, 2019 · 95df7b9 · 95df7b9
2 parents 0902895 + 0ef8a49
commit 95df7b9
Show file tree

Hide file tree

Showing 2 changed files with 49 additions and 19 deletions.
diff --git a/src/Style/CheckboxStyle.php b/src/Style/CheckboxStyle.php
@@ -4,22 +4,37 @@
 
 class CheckboxStyle
 {
-    protected const DEFAULT_STYLES = [
+    private const DEFAULT_STYLES = [
         'markerOn'      => '[✔] ',
         'markerOff'     => '[ ] ',
         'itemExtra'     => '✔',
         'displaysExtra' => false,
     ];
 
-    protected $markerOn = '';
-
-    protected $markerOff = '';
-
-    protected $itemExtra = '';
-
-    protected $displaysExtra = false;
-
-    protected $custom = false;
+    /**
+     * @var string
+     */
+    private $markerOn;
+
+    /**
+     * @var string
+     */
+    private $markerOff;
+
+    /**
+     * @var string
+     */
+    private $itemExtra;
+
+    /**
+     * @var bool
+     */
+    private $displaysExtra;
+
+    /**
+     * @var bool
+     */
+    private $custom = false;
 
     public function __construct()
     {

diff --git a/src/Style/RadioStyle.php b/src/Style/RadioStyle.php
@@ -4,21 +4,36 @@
 
 class RadioStyle
 {
-    protected const DEFAULT_STYLES = [
+    private const DEFAULT_STYLES = [
         'markerOn'      => '[●] ',
         'markerOff'     => '[○] ',
         'itemExtra'     => '✔',
         'displaysExtra' => false,
     ];
 
-    protected $markerOn = '';
-
-    protected $markerOff = '';
-
-    protected $itemExtra = '';
-
-    protected $displaysExtra = false;
-
+    /**
+     * @var string
+     */
+    private $markerOn;
+
+    /**
+     * @var string
+     */
+    private $markerOff;
+
+    /**
+     * @var string
+     */
+    private $itemExtra;
+
+    /**
+     * @var bool
+     */
+    private $displaysExtra;
+
+    /**
+     * @var bool
+     */
     protected $custom = false;
 
     public function __construct()