Update README.md #167
Merged
Update README.md #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix `php fatal error call to unknown function addCustomMapping` when using example code from section "Custom Control Mapping", by changing `addCustomMapping` to `addCustomControlMapping`.
Codecov Report
@@ Coverage Diff @@
## master #167 +/- ##
========================================
Coverage 97.7% 97.7%
Complexity 419 419
========================================
Files 25 25
Lines 1306 1306
========================================
Hits 1276 1276
Misses 30 30Continue to review full report at Codecov.
|
|
Hey there, hope everything is fine with my pull request. Would be glad to get a positive review. Nice package, by the way. |
AydinHassan
approved these changes
Oct 20, 2018
|
Hey there! Thanks for the fix all is good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix php fatal error
call to unknown function addCustomMappingwhen using example code from section Custom Control Mapping by changingaddCustomMappingtoaddCustomControlMapping.