Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selectable item renderer #231

Merged
merged 1 commit into from
Feb 15, 2020
Merged

Selectable item renderer #231

merged 1 commit into from
Feb 15, 2020

Conversation

AydinHassan
Copy link
Member

Abstract away some of the duplicated renderer code for selectable items

@codecov-io
Copy link

Codecov Report

Merging #231 into master will increase coverage by 0.54%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #231      +/-   ##
============================================
+ Coverage     92.07%   92.61%   +0.54%     
+ Complexity      615      612       -3     
============================================
  Files            35       36       +1     
  Lines          1854     1829      -25     
============================================
- Hits           1707     1694      -13     
+ Misses          147      135      -12
Impacted Files Coverage Δ Complexity Δ
src/MenuItem/RadioItem.php 100% <100%> (ø) 17 <0> (-4) ⬇️
src/MenuItem/SelectableItemRenderer.php 100% <100%> (ø) 9 <9> (?)
src/MenuItem/MenuMenuItem.php 91.17% <100%> (+7.84%) 15 <0> (-4) ⬇️
src/MenuItem/CheckboxItem.php 100% <100%> (ø) 16 <0> (-4) ⬇️
src/MenuStyle.php 98.9% <0%> (+2.19%) 77% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d97347e...7ba829f. Read the comment docs.

@AydinHassan AydinHassan merged commit aed1839 into master Feb 15, 2020
@AydinHassan AydinHassan deleted the selectable-item-renderer branch February 15, 2020 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants