Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commonise duplicated assertion in CliMenu. #26

Merged
merged 2 commits into from
Dec 19, 2015
Merged

Commonise duplicated assertion in CliMenu. #26

merged 2 commits into from
Dec 19, 2015

Conversation

thehereward
Copy link
Contributor

No description provided.

@AydinHassan
Copy link
Member

Hi, thanks! This failed the CS checks as underscored methods are not allowed! I can make this change later if you don't have time? You can ignore the appveyor build failure. I will be removing that from PR's soon.

@thehereward
Copy link
Contributor Author

No problem, I can take the underscores out now - old habits die hard!

@codecov-io
Copy link

Current coverage is 55.39%

Merging #26 into master will not affect coverage as of 4a33efb

@@            master     #26   diff @@
======================================
  Files           15      15       
  Stmts          630     630       
  Branches         0       0       
  Methods        138     139     +1
======================================
  Hit            349     349       
  Partial          0       0       
  Missed         281     281       

Review entire Coverage Diff as of 4a33efb

Powered by Codecov. Updated on successful CI builds.

AydinHassan added a commit that referenced this pull request Dec 19, 2015
Commonise duplicated assertion in CliMenu.
@AydinHassan AydinHassan merged commit 8ed4097 into php-school:master Dec 19, 2015
@AydinHassan
Copy link
Member

Thanks!

@AydinHassan
Copy link
Member

I'll get to the other tomorrow, just about to fly 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants