New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#7] Better help command output #30
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @williankeller this is really great! Just a few small requests please :)
app/config.php
Outdated
->setDescription('Install a PHP School workshop.'); | ||
->setDescription('Install a PHP School workshop.') | ||
->setHelp(<<<'EOF' | ||
This command requires a <comment>workshopName</comment> code as argument: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as an
argument
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as all the other commands also
app/config.php
Outdated
->setDescription('Install a PHP School workshop.') | ||
->setHelp(<<<'EOF' | ||
This command requires a <comment>workshopName</comment> code as argument: | ||
<info>workshop-manager <comment>workshopName</comment></info> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is missing %command.name%
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it was, my bad.
Ignore the travis failure - this is due to the auto phar building and you not having access to the secrets. There's probably a way to disable that on PR's but I don't know how yet :D |
Codecov Report
@@ Coverage Diff @@
## master #30 +/- ##
=========================================
Coverage 99.07% 99.07%
Complexity 201 201
=========================================
Files 26 26
Lines 757 757
=========================================
Hits 750 750
Misses 7 7 Continue to review full report at Codecov.
|
Thank you @williankeller ! |
Adding more detail about each command and how to use it as requested under #7 issue.
Feel free to suggest new comments or a new order for items to be displayed