Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#7] Better help command output #30

Merged
merged 3 commits into from Feb 22, 2018
Merged

[#7] Better help command output #30

merged 3 commits into from Feb 22, 2018

Conversation

williankeller
Copy link
Contributor

Adding more detail about each command and how to use it as requested under #7 issue.
Feel free to suggest new comments or a new order for items to be displayed

Copy link
Member

@AydinHassan AydinHassan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @williankeller this is really great! Just a few small requests please :)

app/config.php Outdated
->setDescription('Install a PHP School workshop.');
->setDescription('Install a PHP School workshop.')
->setHelp(<<<'EOF'
This command requires a <comment>workshopName</comment> code as argument:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as an argument

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as all the other commands also

app/config.php Outdated
->setDescription('Install a PHP School workshop.')
->setHelp(<<<'EOF'
This command requires a <comment>workshopName</comment> code as argument:
<info>workshop-manager <comment>workshopName</comment></info>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is missing %command.name%

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it was, my bad.

@AydinHassan
Copy link
Member

Ignore the travis failure - this is due to the auto phar building and you not having access to the secrets. There's probably a way to disable that on PR's but I don't know how yet :D

@williankeller
Copy link
Contributor Author

New commit was made [#7] Fix typo & missing placeholder 1d10b9b

@codecov-io
Copy link

codecov-io commented Feb 22, 2018

Codecov Report

Merging #30 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #30   +/-   ##
=========================================
  Coverage     99.07%   99.07%           
  Complexity      201      201           
=========================================
  Files            26       26           
  Lines           757      757           
=========================================
  Hits            750      750           
  Misses            7        7

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58fe2d5...55bf0e6. Read the comment docs.

@AydinHassan AydinHassan merged commit daedbb1 into php-school:master Feb 22, 2018
@AydinHassan
Copy link
Member

Thank you @williankeller ! self-update in a few minutes and your changes should come through automatically!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants