Ability to override protocol version #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## v5.1 #3 +/- ##
============================================
- Coverage 75.92% 74.38% -1.55%
- Complexity 47 48 +1
============================================
Files 11 10 -1
Lines 216 203 -13
============================================
- Hits 164 151 -13
Misses 52 52
Continue to review full report at Codecov.
|
Guuzen
commented
Mar 31, 2022
Comment on lines
+4
to
+7
| ignoreErrors: | ||
| - | ||
| message: '#does not accept array<string, array\|string>#' | ||
| path: %currentWorkingDirectory%/src/HttpRequest.php |
There was a problem hiding this comment.
This is fixed in phpstan/phpstan#6927
so we can remove it after update phpstan.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Protocol version overriding does not work.