New Block Types #75
Merged
New Block Types #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmbuckley
force-pushed
the
new-block-types
branch
from
4a8689c
to
a66b92b
Compare
alek13
requested changes
Oct 17, 2021
cmbuckley
force-pushed
the
new-block-types
branch
from
a66b92b
to
c51f392
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to add support for dynamic select types. Fixes #74.
Also adds
timepickerelement, and updates functionality forplain_text_input.I have renamed AbstractSelect to AbstractStaticSelect for clarity, which strictly speaking is BC breaking. If desired, I can add a stub class AbstractSelect extending AbstractStaticSelect, marking AbstractSelect as deprecated.