Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand $args array parameters that are described in other functions #49

Merged
merged 29 commits into from
Aug 15, 2022
Merged

Expand $args array parameters that are described in other functions #49

merged 29 commits into from
Aug 15, 2022

Conversation

johnbillion
Copy link
Contributor

@johnbillion johnbillion commented Aug 9, 2022

Fixes #46. Needs testing.

Todo

  • Check each of the ~60 additions to ensure they're correct
  • Add inline docs so our future selves are thankful

@szepeviktor
Copy link
Member

strpos($description, '()')

Very clever.

@johnbillion
Copy link
Contributor Author

This is looking good and we're green ✅ but I want to manually check each of the additions to ensure their correctness because there is an allowance for the parameter names to differ from its inherited function, which could in theory result in the wrong parameter being used.

@johnbillion johnbillion marked this pull request as ready for review August 10, 2022 23:26
visitor.php Outdated Show resolved Hide resolved
johnbillion and others added 2 commits August 15, 2022 18:08
Co-authored-by: Viktor Szépe <viktor@szepe.net>
@szepeviktor
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expand $args array parameters that are described in other functions
2 participants