-
-
Notifications
You must be signed in to change notification settings - Fork 112
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Adding secure schema support, and removing un-used options support.
- Loading branch information
1 parent
a5a61ce
commit 9920fa6
Showing
1 changed file
with
51 additions
and
29 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9920fa6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this make it possible to also get https urls to images? Currently I get links like this:
["http://image.tmdb.org/t/p/h632/rX4LRmkYshMRfQ6lVbeZVAfqVKI.jpg", "http://image.tmdb.org/t/p/h632/mv2DgT9RABBYCxOY4ZHYalYBiUt.jpg", "http://image.tmdb.org/t/p/h632/eZBAmGqwG2q2bFWD3xLTLt69QAb.jpg", "http://image.tmdb.org/t/p/h632/fxOwiq2A41huXU9ltq4zAhpSiEG.jpg"]
9920fa6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, it is direct communication only, if you are making use of the image helper it would require a change in the class.
There's a
secure_base_url
now.9920fa6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Best way to go I think is to just strip the http: part and leave the protocol up to the browser.