New extractor for constraints

[lukepass]

Hello, I created for my project an extractor to get the list of translations from constraints in form (and controller) classes:

class ChangePasswordFormType extends AbstractType
{
    /**
     * @param mixed[]                                           $options
     * @param FormBuilderInterface<FormBuilderInterface|string> $builder
     */
    public function buildForm(FormBuilderInterface $builder, array $options): void
    {
        $builder
            ->add('plainPassword', RepeatedType::class, [
                'type' => PasswordType::class,
                'first_options' => [
                    'constraints' => [
                        new NotBlank([
                            'message' => 'Inserisci la nuova password.',
                        ]),
                        new Length([
                            'min' => 6,
                            'minMessage' => 'La nuova password deve essere di almeno {{ limit }} caratteri.',
                            // max length allowed by Symfony for security reasons
                            'max' => 4096,
                        ]),
                    ],
                    'label' => 'Nuova password',
                ],
                'second_options' => [
                    'label' => 'Ripeti password',
                ],
                'invalid_message' => 'Le due password devono corrispondere.',
                // Instead of being set onto the object directly,
                // this is read and encoded in the controller
                'mapped' => false,
            ])
        ;
    }

    public function configureOptions(OptionsResolver $resolver): void
    {
        $resolver->setDefaults([]);
    }
}

[bocharsky-bw]

Thank you for this contribution!

What about custom constraints? This implementation won't cover them, right? It only works with Symfony predefined constraints as far as I understand?

Also, any chance you could add some tests to cover the use case with constraints you're going to add?

[bocharsky-bw]

If we found the constraint class - should we continue iterating further or stop iteration? I just don't see the value in iterating further

[lukepass]

Unfortunately if I write Assert\NotBlank instead of just NotBlank the "parts" would contain Assert and NotBlank so I need to iterate all of them.

[rvanlaak]

Can't part of finding an appropiate constraint class get caught by checking against extending Symfony\Component\Validator\Constraint?

[lukepass]

How can I check against extending a Constraint class, that would be useful!

[rvanlaak]

A is_subclass_of function call can get used for that https://3v4l.org/jcgXX

[lukepass]

Yes, I know that but I can't use is_subclass_of because in the $part I don't have the fully qualified class name but just the "string" of the class name (e.g. "NotBlank"). nikic/PHP-Parser doesn't return the class FQCN.

[bocharsky-bw]

Do you think we need to add an error about this? Could you explain why it's better than just silently ignore non-string values?

[lukepass]

I don't know, I like to get errors when translating so that I know that the extractor failed on one part but if you want I can just silently ignore it!

[lukepass]

Thank you for this contribution!

What about custom constraints? This implementation won't cover them, right? It only works with Symfony predefined constraints as far as I understand?

Also, any chance you could add some tests to cover the use case with constraints you're going to add?

Yes, unfortunately it will work only for a pre-defined set of constraints. I don't think I can get the class type from the name, right?
I am working on it right now to make a better version (e.g. "minMessage" and other properties, better errors and better code).

[lukepass]

I added more features and a small test suite.

[bocharsky-bw]

Hey @lukepass ! Could you pull the latest changes from master to see if tests pass here?

[bocharsky-bw]

@lukepass could you take a look at failed PHP-CS-Fixer here?

[lukepass]

Yes, the tests are passing. I already used php-cs-fixer on my code but there was a problem with public const (I am using PHPCSFixer as ruleset).

[bocharsky-bw]

Cool! Looks good to me 👍

Thank you for this contribution and sorry for the delay!