Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added validation for the ajax requests #8

Merged
merged 2 commits into from Dec 5, 2016
Merged

Added validation for the ajax requests #8

merged 2 commits into from Dec 5, 2016

Conversation

Nyholm
Copy link
Member

@Nyholm Nyholm commented Dec 5, 2016

Fixed issue #6

I did not use the serializer component for two reasons.

  1. I try to keep the dependencies to a minimum.
  2. It would require us to add normalizers to the serializer. Configuring the serializer service would be more lines than the current use case.

This PR is using proper validation though.

@Nyholm
Copy link
Member Author

Nyholm commented Dec 5, 2016

@damienalexandre what do you think about this?

@damienalexandre
Copy link
Contributor

Looks good to me 👍

@Nyholm
Copy link
Member Author

Nyholm commented Dec 5, 2016

Awesome. Thanks!

@Nyholm Nyholm merged commit f3c39aa into master Dec 5, 2016
@Nyholm Nyholm deleted the patch-2 branch December 5, 2016 18:26
@Nyholm Nyholm mentioned this pull request Dec 6, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damienalexandre damienalexandre damienalexandre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Nyholm @damienalexandre